Musepack Forums

Musepack Forums (https://forum.musepack.net/index.php)
-   Development (https://forum.musepack.net/forumdisplay.php?f=11)
-   -   cleaning up mpc source code (https://forum.musepack.net/showthread.php?t=87)

kuniklo 30 November 2004 06:43 pm

cleaning up mpc source code
 
Would you guys consider any patches to fix all the compiler warnings that the mpc code currently generates? It's pretty ugly.

Shy 30 November 2004 08:22 pm

Have you ever seen the compiler warnings libvorbis generates? Do you even know what those warnings mean?

kuniklo 30 November 2004 08:57 pm

Quote:

Have you ever seen the compiler warnings libvorbis generates? Do you even know what those warnings mean?
Libvorbis generates virtually no warnings when compiled on my Debian Linux x86 box.

Are you referring to the mpc warnings in your second question? They're mostly caused by inconsistent type declarations (float vs double, unsigned vs signed etc).

Shy 30 November 2004 10:26 pm

Quote:

Libvorbis generates virtually no warnings when compiled on my Debian Linux x86 box.
That's not the case with MSVC on Windows. And still it doesn't matter much, because like with musepack, the warnings don't mean much as no functionality is affected.
It would be good if issues like this could be taken care of, but it's at a much lower priority at the moment than making other arrangements in the code, such as removing unused and outdated features.

kuniklo 30 November 2004 11:10 pm

Quote:

Quote:

Libvorbis generates virtually no warnings when compiled on my Debian Linux x86 box.
That's not the case with MSVC on Windows. And still it doesn't matter much, because like with musepack, the warnings don't mean much as no functionality is affected.
It would be good if issues like this could be taken care of, but it's at a much lower priority at the moment than making other arrangements in the code, such as removing unused and outdated features.
I agree it's not a top priority but it's something I could help with now while becoming more familiar with the code in the process.

Shy 30 November 2004 11:30 pm

(Instead of only sending a PM) I'll take this opportunity to mention that if anyone thinks they can contribute to Musepack development, everyone is welcome to join our IRC network as the main development is done and coordinated there.


All times are GMT. The time now is 09:24 pm.

Powered by vBulletin® Version 3.8.11 Beta 2
Copyright ©2000 - 2020, vBulletin Solutions Inc.