View Single Post
Old 24 April 2008, 10:56 pm   #32
slomo
Member
 
Join Date: Mar 2008
Posts: 7
Default

Quote:
Originally Posted by r2d View Post
That's good
...and committed

Quote:
Originally Posted by r2d View Post
I moved mpc_bits_reader definition in mpcdec.h, thanks for your help.
Great, thanks

Another thing I noticed is, that libreplaygain exports more symbols than what is shown as public API by the header file. Could you add the same visibility stuff as for libmpcdec to libreplaygain? Apart from that it would be nice if libreplaygain would get properly namespaced (i.e. prefixed) symbols. Stuff like AnalyzeSamples is a good candidate for causing conflicts later...
slomo is offline   Reply With Quote