View Single Post
Old 24 June 2009, 09:14 pm   #6
r2d
Musepack developer
 
Join Date: Sep 2006
Location: Villeurbanne - France
Posts: 36
Default

thanks for your patch, tried to use it (I'm really not good at autotools, and don't even try to improve). Here are my remarks :

- -fpic seems to have disappeared from /libmpcdec/Makefile.am
- got this warning : cc1: warning: command line option "-fvisibility-inlines-hidden" is valid for C++/ObjC++ but not for C
- what is the difference between INCLUDES and AM_CPPFLAGS ?
- kdevelop used AM_CPPFLAGS to add extra includes (local libreplaygain includes) but your patch add AM_CPPFLAGS = , overriding it if already defined (use += ?)
- do your old patch are included in this one ? Seems to me they were never commited (and I can't download the attached zip)

Thanks for your help

Nicolas
r2d is offline   Reply With Quote