View Single Post
Old 25 June 2009, 07:05 am   #7
Dr. Fiemost
Member
 
Join Date: Jun 2008
Posts: 9
Default

Quote:
Originally Posted by r2d View Post
- -fpic seems to have disappeared from /libmpcdec/Makefile.am
pic flags are automatically handled by libtool

Quote:
- got this warning : cc1: warning: command line option "-fvisibility-inlines-hidden" is valid for C++/ObjC++ but not for C
my mistake, I'll remove this flag

Quote:
- what is the difference between INCLUDES and AM_CPPFLAGS ?
they are the same, INCLUDES is the old and deprecated version

Quote:
- kdevelop used AM_CPPFLAGS to add extra includes (local libreplaygain includes) but your patch add AM_CPPFLAGS = , overriding it if already defined (use += ?)
AM_CPPFLAGS contains the preprocessor flags.
I've used += to add more flags when the variable is already defined, for example in mpgain where AM_CFLAGS is set to -ffast-math, or in mpcenc where TRUE and FALSE are defined (but I think the latter really belongs to preprocessor)

Quote:
- do your old patch are included in this one ? Seems to me they were never commited (and I can't download the attached zip)
If I recall well the old patches were integreted, anyway the new patch was made against SVN.

Quote:
Thanks for your help

Nicolas
Thank you for your feedback, I'll soon post an updated patch.

Leandro
Dr. Fiemost is offline   Reply With Quote