Musepack Forums  

Go Back   Musepack Forums > Main > Development

Reply
 
Thread Tools Search this Thread Display Modes
Old 06 June 2008, 09:07 am   #1
Dr. Fiemost
Member
 
Join Date: Jun 2008
Posts: 9
Default SV8 and autotools

Hi,

is the autotool build method being mantained in SV8?
I downloaded libmpc from SVN and after doing a "make dist" the package was missing some header files.
Also I had some troubles cross-compiling the sources with Mingw.

If someone is interested I can send the patch to fix these issues.
Dr. Fiemost is offline   Reply With Quote
Old 26 June 2008, 08:53 am   #2
Dr. Fiemost
Member
 
Join Date: Jun 2008
Posts: 9
Default

Ok, I've attached the patches.

libmpcs-0.1-headers-fix.patch fixes the problem with make dist
libmpcs-0.1-mingw-fix.patch fixes the problem with cross-compiling

Best Regards,
Leandro
Dr. Fiemost is offline   Reply With Quote
Old 28 June 2008, 10:24 am   #3
Seed
Musepack Nanny
 
Seed's Avatar
 
Join Date: Jul 2004
Posts: 168
Default

Thanks
Seed is offline   Reply With Quote
Old 23 June 2009, 07:17 pm   #4
Dr. Fiemost
Member
 
Join Date: Jun 2008
Posts: 9
Default

I did some more work on autotooled build mainly to support symbol visibility on MinGW.
I had to change the MPC_API definition in mpc_types.h to add the __declspec stuff.

Other changes:
*mpcchap build must be enabled with --enable-mpcchap;
*mpcgain is built only if replaygain is installed;
*-fvisibility-hidden is added only for gcc4 on Linux;
* fixed an error when building mpcdec on MinGW since crtdbg.h is a Visual Studio feature.

The patch has been made against svn 442 and tested on Linux and MinGW.
Dr. Fiemost is offline   Reply With Quote
Old 24 June 2009, 01:19 pm   #5
Seed
Musepack Nanny
 
Seed's Avatar
 
Join Date: Jul 2004
Posts: 168
Default

Thanks again. I'm sure some will find it useful
Seed is offline   Reply With Quote
Old 24 June 2009, 09:14 pm   #6
r2d
Musepack developer
 
Join Date: Sep 2006
Location: Villeurbanne - France
Posts: 36
Default

thanks for your patch, tried to use it (I'm really not good at autotools, and don't even try to improve). Here are my remarks :

- -fpic seems to have disappeared from /libmpcdec/Makefile.am
- got this warning : cc1: warning: command line option "-fvisibility-inlines-hidden" is valid for C++/ObjC++ but not for C
- what is the difference between INCLUDES and AM_CPPFLAGS ?
- kdevelop used AM_CPPFLAGS to add extra includes (local libreplaygain includes) but your patch add AM_CPPFLAGS = , overriding it if already defined (use += ?)
- do your old patch are included in this one ? Seems to me they were never commited (and I can't download the attached zip)

Thanks for your help

Nicolas
r2d is offline   Reply With Quote
Old 25 June 2009, 07:05 am   #7
Dr. Fiemost
Member
 
Join Date: Jun 2008
Posts: 9
Default

Quote:
Originally Posted by r2d View Post
- -fpic seems to have disappeared from /libmpcdec/Makefile.am
pic flags are automatically handled by libtool

Quote:
- got this warning : cc1: warning: command line option "-fvisibility-inlines-hidden" is valid for C++/ObjC++ but not for C
my mistake, I'll remove this flag

Quote:
- what is the difference between INCLUDES and AM_CPPFLAGS ?
they are the same, INCLUDES is the old and deprecated version

Quote:
- kdevelop used AM_CPPFLAGS to add extra includes (local libreplaygain includes) but your patch add AM_CPPFLAGS = , overriding it if already defined (use += ?)
AM_CPPFLAGS contains the preprocessor flags.
I've used += to add more flags when the variable is already defined, for example in mpgain where AM_CFLAGS is set to -ffast-math, or in mpcenc where TRUE and FALSE are defined (but I think the latter really belongs to preprocessor)

Quote:
- do your old patch are included in this one ? Seems to me they were never commited (and I can't download the attached zip)
If I recall well the old patches were integreted, anyway the new patch was made against SVN.

Quote:
Thanks for your help

Nicolas
Thank you for your feedback, I'll soon post an updated patch.

Leandro
Dr. Fiemost is offline   Reply With Quote
Old 26 June 2009, 10:16 am   #8
Dr. Fiemost
Member
 
Join Date: Jun 2008
Posts: 9
Default

Here is the new patch against SVN 444.
Dr. Fiemost is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off



All times are GMT. The time now is 05:31 am.


Powered by vBulletin® Version 3.8.11 Beta 2
Copyright ©2000 - 2017, vBulletin Solutions Inc.