Musepack Forums  

Go Back   Musepack Forums > Main > Development

Reply
 
Thread Tools Search this Thread Display Modes
Old 12 August 2004, 11:33 pm   #1
miksha
Member
 
Join Date: Aug 2004
Location: Where People Are Nice
Posts: 22
Default Slighthly modified Winamp MPC plugin!

I changed code for Winamp 2.xx|5.xx MPC plugin [v0.98] to skip tracks with dead entries on a list. It was quite annoying (to me) when plugin reported an error on dead track in a playlist while stopping winamp. Now it just skips nonexisting songs in the playlist.

If interested ask Ben Dor to place it on a site.

Regards, Miksha!
miksha is offline   Reply With Quote
Old 13 August 2004, 06:50 pm   #2
Lefungus
Procrastinator
 
Lefungus's Avatar
 
Join Date: Jul 2004
Posts: 131
Default

Why don't you update the latest version of winamp plugin, ie 0.99 instead of 0.98. Case is currently maintaining these winamp plugins (if i'm not wrong), so maybe you should send him a patch against this version
Lefungus is offline   Reply With Quote
Old 13 August 2004, 08:31 pm   #3
miksha
Member
 
Join Date: Aug 2004
Location: Where People Are Nice
Posts: 22
Default

Well, go to http://www.saunalahti.fi/cse/mpc/winamp/index.html and tell me if you can find source for v0.99. I can't. Version 0.99 is still alpha on Case's site and 0.98 is beta.

I did this mainly for myself and it was just my good will to share it with others. You don't have to attack me for that. Also I have lousy internet connection and I can' alert all people related to MPC development.

Regards, Miksha
miksha is offline   Reply With Quote
Old 14 August 2004, 11:05 am   #4
Lefungus
Procrastinator
 
Lefungus's Avatar
 
Join Date: Jul 2004
Posts: 131
Default

I don't think i *attacked* you...
I'll try to see if we can get those 0.99d sources instead so you can patch this one. We'll be glad to host your modified version after
Lefungus is offline   Reply With Quote
Old 14 August 2004, 11:25 am   #5
@muse
Guest
 
Join Date: Aug 2004
Posts: 16
Default

Hello.

Just a impression, it seems like the musepack section on cases server
isn`t maintained , but loads of foobar. So i assume he maybe got himself
another interest.. ? (please arrest me if am wrong.).

@muse
@muse is offline   Reply With Quote
Old 14 August 2004, 01:57 pm   #6
miksha
Member
 
Join Date: Aug 2004
Location: Where People Are Nice
Posts: 22
Default

I tried to contact Case through the e-mail contact at his sight and I received response from Janne Hyvärinen who sent me this link: http://www.saunalahti.fi/cse/mpc/source/wi...p-0.99d_src.zip. I will download it and patch the code and I can resend this new plugin to www.musepack.net. But I will send patch to Janne Hyvärinen, too. I would also very much like if all new versions of Winamp plugin would work the way I changed it for myself.

And yes, I also think that Case's site is a bit outdated or maybe not so regularly updated. Maybe I'm wrong.

Regards, Miksha!
miksha is offline   Reply With Quote
Old 16 August 2004, 12:24 am   #7
miksha
Member
 
Join Date: Aug 2004
Location: Where People Are Nice
Posts: 22
Default

I changed code in v0.99d and I will try to send it to Shy. If anyone interested ofcourse. Also I sent patched segment of code to Janne.

Regards, Miksha
miksha is offline   Reply With Quote
Old 27 August 2004, 11:37 am   #8
mll
Member
 
mll's Avatar
 
Join Date: Aug 2004
Posts: 24
Default

I for one am *pretty much* interested : the evoqued popup annoys me too !

Thansk for your initiative ! Hope it will be on musepack.net soon...

Cheers,

MLL
mll is offline   Reply With Quote
Old 28 August 2004, 03:05 am   #9
miksha
Member
 
Join Date: Aug 2004
Location: Where People Are Nice
Posts: 22
Default

Thanx! As people on www.musepack.net does not seam too much interested, I asked my friend to post it at his site. You can download it from:

http://kotnik.ns-linux.org/mpc/

Also there will be soon WhereIsIt plugin for MPC files, which works much faster than the last one. (You can visit the main page and find some interesting stuff also at: http://kotnik.ns-linux.org)



Regards Miksha!
miksha is offline   Reply With Quote
Old 28 August 2004, 08:48 pm   #10
Shy
Admin
 
Shy's Avatar
 
Join Date: Jul 2004
Posts: 370
Default

It's not that the people on Musepack.net don't want to add it, it's that there has been very little to no request of it, so it wasn't very high on people's priority lists, including the main programmer's (Case).
Recently he found some time to work on it. Apparently he didn't receive, or misplaced miksha's fix, so he added the same kind of fix on his own, and the new version is now added to the site (including the source code).
Thanks for your annotation of this issue, and for your work, Miksha.
Shy is offline   Reply With Quote
Old 29 August 2004, 12:59 am   #11
miksha
Member
 
Join Date: Aug 2004
Location: Where People Are Nice
Posts: 22
Default

I downloaded the source you mentioned (v0.99e) & its functionality is not much different than the previous (v0.99d). Error messages are just blocked, but Winamp still gets stopped. There is no crucial difference. Clicking once or twice is pretty much same to me. What I did was when (just one) error "file doesn't exist" occurs, Winamp jumps to another song and you don't have to click OK on error message or start Winamp to play by clicking on another song. When other errors occur you get message boxes normally.

I'd like to ask you for a Case's contact e-mail address if available. Thanx!

Regards, Miksha
miksha is offline   Reply With Quote
Old 29 August 2004, 03:23 pm   #12
Case
Member
 
Case's Avatar
 
Join Date: Aug 2004
Posts: 1
Default

That was a stupid mistake on my part. Fixed in 0.99f.
Case is offline   Reply With Quote
Old 30 August 2004, 05:20 pm   #13
mll
Member
 
mll's Avatar
 
Join Date: Aug 2004
Posts: 24
Default

IMHO, this tread is a typical example of how the -small- MPC developpers community needs coordination, collaboration, and mostly communication.

I believe that the new musepack.net, and the people behind it, will help.

Whatever plug-in I'll use, thanks a lot to Case and Miksha for their works, and hopefully we won't fork the Winamp plugin developement.

Cheers,

MLL
mll is offline   Reply With Quote
Old 30 August 2004, 08:35 pm   #14
miksha
Member
 
Join Date: Aug 2004
Location: Where People Are Nice
Posts: 22
Default

You're absolutely right! I had to use provocation with some people to change things. Apologies to everyone (particulary to Lefungus, who really did a great job with XMMS/BMP mpc plugin). On the other hand some people deserved it because of their attitude.

This process should work in a much more different way. I also stand behind idea that it should be e.g. just one Winamp plugin instead of lot of variations. Some ideas are not interesting to many people, I admit. Maybe error popup isn't crucial to many? But if we think that way, we could say that audio formats different to MP3 are also not crucial to many and stop developing MPC. I just want to say that any suggestion should be considered, and if it's worth, built into the official release. Main programmers cannot see all bugs and get all ideas on their own. Please don't get me wrong, because I really respect all the work they've done and I'm gratefull to them.

Regards, Miksha
miksha is offline   Reply With Quote
Old 30 August 2004, 09:55 pm   #15
miksha
Member
 
Join Date: Aug 2004
Location: Where People Are Nice
Posts: 22
Default

I accidently found another bug in Winamp plugin v0.99f related to error messages. When you open a playlist with no valid entries at all, Winamp gets freezed (not responding). You can only call Windows Task Manager and simply kill it. When there is at least on valid song in playlist it skips all nonexisting. The way I changed it, it just gets stopped (when no valid song at all) or skips (when there is at least one valid).

Source that was changed by me can be found at http://kotnik.ns-linux.org/mpc/ . I only changed in_mpc.cpp (comment string is "//miksha added").

Regards, Miksha
miksha is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
Any chance to see an updated Winamp plugin? - That supports 1.16 fast seeking donpipo MPC for Windows 2 30 November 2006 02:12 am
Crash in winamp with the musepack plugin cmamet MPC for Windows 15 05 September 2005 11:46 pm
WhereIsIt MPC Description Plugin miksha MPC for Windows 5 31 August 2005 05:19 pm
MPC Files act strange in when playing with Winamp lawkie MPC for Windows 1 09 May 2005 06:48 pm
Winamp plugin odd behaviour drmrbrewer MPC for Windows 4 08 April 2005 07:54 pm


All times are GMT. The time now is 11:22 am.


Powered by vBulletin® Version 3.8.11 Beta 2
Copyright ©2000 - 2019, vBulletin Solutions Inc.