cleaning up mpc source code

[kuniklo]

Would you guys consider any patches to fix all the compiler warnings that the mpc code currently generates? It's pretty ugly.

[Shy]

Have you ever seen the compiler warnings libvorbis generates? Do you even know what those warnings mean?

[kuniklo]

Have you ever seen the compiler warnings libvorbis generates? Do you even know what those warnings mean?

Libvorbis generates virtually no warnings when compiled on my Debian Linux x86 box.

Are you referring to the mpc warnings in your second question? They're mostly caused by inconsistent type declarations (float vs double, unsigned vs signed etc).

[Shy]

Libvorbis generates virtually no warnings when compiled on my Debian Linux x86 box.

That's not the case with MSVC on Windows. And still it doesn't matter much, because like with musepack, the warnings don't mean much as no functionality is affected.
It would be good if issues like this could be taken care of, but it's at a much lower priority at the moment than making other arrangements in the code, such as removing unused and outdated features.

[kuniklo]

That's not the case with MSVC on Windows. And still it doesn't matter much, because like with musepack, the warnings don't mean much as no functionality is affected.
It would be good if issues like this could be taken care of, but it's at a much lower priority at the moment than making other arrangements in the code, such as removing unused and outdated features.

I agree it's not a top priority but it's something I could help with now while becoming more familiar with the code in the process.

[Shy]

(Instead of only sending a PM) I'll take this opportunity to mention that if anyone thinks they can contribute to Musepack development, everyone is welcome to join our IRC network as the main development is done and coordinated there.