Musepack Forums  

Go Back   Musepack Forums > Main > Development

Reply
 
Thread Tools Search this Thread Display Modes
Old 30 November 2004, 06:43 pm   #1
kuniklo
Senior Member
 
kuniklo's Avatar
 
Join Date: Aug 2004
Location: Emeryville, CA
Posts: 52
Default cleaning up mpc source code

Would you guys consider any patches to fix all the compiler warnings that the mpc code currently generates? It's pretty ugly.
kuniklo is offline   Reply With Quote
Old 30 November 2004, 08:22 pm   #2
Shy
Admin
 
Shy's Avatar
 
Join Date: Jul 2004
Posts: 370
Default

Have you ever seen the compiler warnings libvorbis generates? Do you even know what those warnings mean?
Shy is offline   Reply With Quote
Old 30 November 2004, 08:57 pm   #3
kuniklo
Senior Member
 
kuniklo's Avatar
 
Join Date: Aug 2004
Location: Emeryville, CA
Posts: 52
Default

Quote:
Have you ever seen the compiler warnings libvorbis generates? Do you even know what those warnings mean?
Libvorbis generates virtually no warnings when compiled on my Debian Linux x86 box.

Are you referring to the mpc warnings in your second question? They're mostly caused by inconsistent type declarations (float vs double, unsigned vs signed etc).
kuniklo is offline   Reply With Quote
Old 30 November 2004, 10:26 pm   #4
Shy
Admin
 
Shy's Avatar
 
Join Date: Jul 2004
Posts: 370
Default

Quote:
Libvorbis generates virtually no warnings when compiled on my Debian Linux x86 box.
That's not the case with MSVC on Windows. And still it doesn't matter much, because like with musepack, the warnings don't mean much as no functionality is affected.
It would be good if issues like this could be taken care of, but it's at a much lower priority at the moment than making other arrangements in the code, such as removing unused and outdated features.
Shy is offline   Reply With Quote
Old 30 November 2004, 11:10 pm   #5
kuniklo
Senior Member
 
kuniklo's Avatar
 
Join Date: Aug 2004
Location: Emeryville, CA
Posts: 52
Default

Quote:
Quote:
Libvorbis generates virtually no warnings when compiled on my Debian Linux x86 box.
That's not the case with MSVC on Windows. And still it doesn't matter much, because like with musepack, the warnings don't mean much as no functionality is affected.
It would be good if issues like this could be taken care of, but it's at a much lower priority at the moment than making other arrangements in the code, such as removing unused and outdated features.
I agree it's not a top priority but it's something I could help with now while becoming more familiar with the code in the process.
kuniklo is offline   Reply With Quote
Old 30 November 2004, 11:30 pm   #6
Shy
Admin
 
Shy's Avatar
 
Join Date: Jul 2004
Posts: 370
Default

(Instead of only sending a PM) I'll take this opportunity to mention that if anyone thinks they can contribute to Musepack development, everyone is welcome to join our IRC network as the main development is done and coordinated there.
Shy is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
source code crazee_canuck General 3 15 November 2006 09:40 pm
Need Someone's Help With MPC (SV8?) Decoding. Ptomaine Development 3 10 August 2006 06:13 pm
My return to using MPC... Gow General 11 01 July 2006 01:02 am
low level clicks and noise davidm General 20 29 June 2005 09:05 am
compiling source code on linux ratmmmam MPC for UNIX 1 11 January 2005 05:23 pm


All times are GMT. The time now is 09:56 pm.


Powered by vBulletin® Version 3.8.11 Beta 2
Copyright ©2000 - 2019, vBulletin Solutions Inc.