SV8 and autotools

[Dr. Fiemost]

Hi,

is the autotool build method being mantained in SV8?
I downloaded libmpc from SVN and after doing a "make dist" the package was missing some header files.
Also I had some troubles cross-compiling the sources with Mingw.

If someone is interested I can send the patch to fix these issues.

[Dr. Fiemost]

Ok, I've attached the patches.

libmpcs-0.1-headers-fix.patch fixes the problem with make dist
libmpcs-0.1-mingw-fix.patch fixes the problem with cross-compiling

Best Regards,
Leandro

[Seed]

Thanks

[Dr. Fiemost]

I did some more work on autotooled build mainly to support symbol visibility on MinGW.
I had to change the MPC_API definition in mpc_types.h to add the __declspec stuff.

Other changes:
*mpcchap build must be enabled with --enable-mpcchap;
*mpcgain is built only if replaygain is installed;
*-fvisibility-hidden is added only for gcc4 on Linux;
* fixed an error when building mpcdec on MinGW since crtdbg.h is a Visual Studio feature.

The patch has been made against svn 442 and tested on Linux and MinGW.

[Seed]

Thanks again. I'm sure some will find it useful

[r2d]

thanks for your patch, tried to use it (I'm really not good at autotools, and don't even try to improve). Here are my remarks :

- -fpic seems to have disappeared from /libmpcdec/Makefile.am
- got this warning : cc1: warning: command line option "-fvisibility-inlines-hidden" is valid for C++/ObjC++ but not for C
- what is the difference between INCLUDES and AM_CPPFLAGS ?
- kdevelop used AM_CPPFLAGS to add extra includes (local libreplaygain includes) but your patch add AM_CPPFLAGS = , overriding it if already defined (use += ?)
- do your old patch are included in this one ? Seems to me they were never commited (and I can't download the attached zip)

Thanks for your help

Nicolas

[Dr. Fiemost]

Originally Posted by r2d

- -fpic seems to have disappeared from /libmpcdec/Makefile.am

pic flags are automatically handled by libtool

- got this warning : cc1: warning: command line option "-fvisibility-inlines-hidden" is valid for C++/ObjC++ but not for C

my mistake, I'll remove this flag

- what is the difference between INCLUDES and AM_CPPFLAGS ?

they are the same, INCLUDES is the old and deprecated version

- kdevelop used AM_CPPFLAGS to add extra includes (local libreplaygain includes) but your patch add AM_CPPFLAGS = , overriding it if already defined (use += ?)

AM_CPPFLAGS contains the preprocessor flags.
I've used += to add more flags when the variable is already defined, for example in mpgain where AM_CFLAGS is set to -ffast-math, or in mpcenc where TRUE and FALSE are defined (but I think the latter really belongs to preprocessor)

- do your old patch are included in this one ? Seems to me they were never commited (and I can't download the attached zip)

If I recall well the old patches were integreted, anyway the new patch was made against SVN.

Thanks for your help

Nicolas

Thank you for your feedback, I'll soon post an updated patch.

Leandro

[Dr. Fiemost]

Here is the new patch against SVN 444.